[PATCH] D24917: Resolve response file names relative to including file

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 11:01:51 PDT 2016


rnk added inline comments.


> CommandLine.cpp:947
>      SmallVector<const char *, 0> ExpandedArgv;
>      if (!ExpandResponseFile(Arg + 1, Saver, Tokenizer, ExpandedArgv,
> +                            MarkEOLs, RelativeNames)) {

Can we do the relativization logic here rather than doing two complete scans of the response file tokens? Presumably they will be large.

https://reviews.llvm.org/D24917





More information about the llvm-commits mailing list