[PATCH] D25240: [ELF] Emit warning instead of error, when undefined symbol is not really used.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 09:21:33 PDT 2016


ruiu added inline comments.


> ruiu wrote in Writer.cpp:320
> Instead of adding a new bit to the symbol, I'd do this here.
> 
>   // Ignore symbols in garbage-collected sections.
>   // We could report them, but we don't because GNU linkers don't.
>   if (Sym->symbol()->includeInDynsym())
>     if (auto *D = dyn_cast<DefinedRegular<ELFT>(Sym))
>       if (!D->Section.Live)
>         return;

Ignore this comment -- I deleted it before sending a message but it wasn't removed for some reason.

Repository:
  rL LLVM

https://reviews.llvm.org/D25240





More information about the llvm-commits mailing list