[PATCH] D25237: [ELF] - Do not crash on MIPS if there is no object files in input.

[George Rimar via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL283226: [ELF] - Do not crash on MIPS if there is no object files in input. (authored by grimar).

Changed prior to commit:
  https://reviews.llvm.org/D25237?vs=73476&id=73487#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D25237

Files:
  lld/trunk/ELF/Mips.cpp
  lld/trunk/test/ELF/mips-no-objects.s


Index: lld/trunk/ELF/Mips.cpp
===================================================================
--- lld/trunk/ELF/Mips.cpp
+++ lld/trunk/ELF/Mips.cpp
@@ -285,6 +285,8 @@
   std::vector<FileFlags> V;
   for (elf::ObjectFile<ELFT> *F : Symtab<ELFT>::X->getObjectFiles())
     V.push_back({F->getName(), F->getObj().getHeader()->e_flags});
+  if (V.empty())
+    return 0;
   checkFlags(V);
   return getMiscFlags(V) | getPicFlags(V) | getArchFlags(V);
 }
Index: lld/trunk/test/ELF/mips-no-objects.s
===================================================================
--- lld/trunk/test/ELF/mips-no-objects.s
+++ lld/trunk/test/ELF/mips-no-objects.s
@@ -0,0 +1,5 @@
+# REQUIRES: mips
+# RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux %s -o %t.o
+# RUN: ld.lld %t.o -shared -o %t.so
+# RUN: ld.lld %t.so -shared -o %t2.so
+# RUN: llvm-readobj %t2.so > /dev/null 2>&1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25237.73487.patch
Type: text/x-patch
Size: 872 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161004/73a9217c/attachment.bin>