[PATCH] D24796: [SLPVectorizer] Fix for PR25748: reduction vectorization after loop unrolling.

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 07:29:34 PDT 2016


mssimpso added inline comments.


> ABataev wrote in SLPVectorizer.cpp:1797
> Yes, that's right

I think it would be a good idea to rework this function so that it checks the fully vectorizable property up to max(MinTreeSize, VectorizeableTree.size()). The current state of things is a bit confusing. MinTreeSize defines what is "tiny" yet here we assume tiny means a height of two. What do you think?

https://reviews.llvm.org/D24796





More information about the llvm-commits mailing list