[PATCH] D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads

[Ariel Ben-Yehuda via llvm-commits]

arielb1 added inline comments.


> hfinkel wrote in InstCombineLoadStoreAlloca.cpp:386
> What is the:
> 
>   N->getNumOperands() == 2
> 
> supposed to be checking? The range metadata can have any even number of operands; and we already have an assert for this in llvm::getConstantRangeFromMetadata.

Cargo cult copypasta. Will remove

> hfinkel wrote in InstCombineLoadStoreAlloca.cpp:387
> Indentation looks odd here. Tabs?

Sure.

Repository:
  rL LLVM

https://reviews.llvm.org/D25215