[PATCH] D24925: [testsuite] turn fp-contract off because we can check those results more precisely

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 03:17:00 PDT 2016


rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

Rejecting it for the same reasons as expressed in https://reviews.llvm.org/D25194 and the other similar threads.

> "Ideally, we would run everything again with -ffp-contract=on and fix any output-checking that is not prepared for that possibility."

That's what we realistically need to do, not ideally.

cheers,
--renato


https://reviews.llvm.org/D24925





More information about the llvm-commits mailing list