[PATCH] D25066: [ELF] Do not merge sections in case of relocatable object generation
Peter Smith via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 4 02:59:41 PDT 2016
peter.smith added a comment.
I think the implementation looks ok. I have made some suggestions to improve the comment, but I understood what it meant as it was written.
> InputFiles.cpp:179
> return false;
>
> + // Do not merge sections if generate a relocatable object. It makes the code
A few suggestions for the comment.
"if generate" -> "if generating"
"update relocations addend" -> "update relocation addends"
"separate output ones" -> "separate OutputSections"
Repository:
rL LLVM
https://reviews.llvm.org/D25066
More information about the llvm-commits
mailing list