[PATCH] D25218: [asan] Switch to using dynamic shadow offset on iOS

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 18:41:32 PDT 2016


kcc accepted this revision.
kcc added a reviewer: kcc.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM
Does it deserve any kind of test?



> sanitizer_mac.cc:753
> +  // 4KB on 32-bit and 4GB on 64-bit.
> +#if SANITIZER_WORDSIZE == 32
> +  #define START_ADDRESS 0x000000001000;

if() instead of #if, please

https://reviews.llvm.org/D25218





More information about the llvm-commits mailing list