[PATCH] D25198: AMDGPU/SI: Fix LowerParameter() for i16 arguments

[Matt Arsenault via llvm-commits]

arsenm added inline comments.


> SIISelLowering.cpp:587-592
>    if (MemVT.isFloatingPoint())
> -    ExtTy = ISD::EXTLOAD;
> +    Val = DAG.getNode(ISD::FP_EXTEND, SL, VT, Load);
> +  else if (Signed)
> +    Val = DAG.getSExtOrTrunc(Load, SL, VT);
> +  else
> +    Val = DAG.getZExtOrTrunc(Load, SL, VT);

When is the trunc case necessary? Since the FP case only needs to handle extend this looks weird to me

https://reviews.llvm.org/D25198