[PATCH] D25088: [x86] Fixing PR28755 by precomputing the address used in CMPXCHG8B

[Quentin Colombet via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

One last nitpick, don't need to go through another round of review, just commit directly.

Cheers,
Q.



> X86InstrBuilder.h:129
> +  MI->getOperand(Operand + 3).setImm(0);
> +  MI->getOperand(Operand + 4).setReg(0);
> +}

Could you add a comment on which operand are what?
I admit I don't remember at first when looking at the code why we need 1 for Operand + 1, until I realize, right this is the scale :).

https://reviews.llvm.org/D25088