[PATCH] D18226: Codegen: Tail-duplicate during placement.

[Kyle Butt via llvm-commits]

iteratee added a comment.

Please take a look. I cleaned up the issues you pointed out and added comments.



> davidxl wrote in MachineBlockPlacement.cpp:1826
> Missing coma. ".. it was removed, markChainSuccessors .."

I split the sentence into 2 and then added a comma. It's easier to read now.

> davidxl wrote in MachineBlockPlacement.cpp:1836
> Add a comment here that Chain End is updated when DupBB is removed by the removal call back.
> 
> There also seem to be a bug here: if TailDup happens, but DupBB is not removed, the loop will check the same BB again. Should it just break the loop when removed is not true?

I added some comments.

Currently, duplication to layout predecessor only occurs if the block is removed. I added a comment about that as well.

https://reviews.llvm.org/D18226