[PATCH] D24686: [support] Some improvements to StringSwitch

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D24686#559231, @zturner wrote:

> Here's the updated patch, including Chandler's suggestion of using `Optional` instead of `Error`.  I thought about this some more and I don't see the value-add associated with splitting this apart.  Primarily because I abandoned the variadic templates idea.  As such, the `Lower` versions of the functions must go in at the same time as the `Lower` versions of the tests, and those two things constitue 90% of the entire patch (the rest are just case-sensitive versions of the tests for existing functions which have not changed in this patch).
>
> Let me know if you disagree.


I kind of do... It makes the code review and any potential reverts much more clear IMO.


https://reviews.llvm.org/D24686