[llvm] r283125 - Use getSize instead of data().size(). NFC.
Rafael Espindola via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 3 10:49:19 PDT 2016
Author: rafael
Date: Mon Oct 3 12:49:19 2016
New Revision: 283125
URL: http://llvm.org/viewvc/llvm-project?rev=283125&view=rev
Log:
Use getSize instead of data().size(). NFC.
Also assert isFinalized in getSize(). This just reduces the noise from
another patch.
Modified:
llvm/trunk/include/llvm/MC/StringTableBuilder.h
llvm/trunk/lib/MC/MachObjectWriter.cpp
llvm/trunk/lib/MC/StringTableBuilder.cpp
llvm/trunk/tools/yaml2obj/yaml2elf.cpp
Modified: llvm/trunk/include/llvm/MC/StringTableBuilder.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/StringTableBuilder.h?rev=283125&r1=283124&r2=283125&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/StringTableBuilder.h (original)
+++ llvm/trunk/include/llvm/MC/StringTableBuilder.h Mon Oct 3 12:49:19 2016
@@ -61,7 +61,7 @@ public:
return StringIndexMap;
}
- size_t getSize() const { return Size; }
+ size_t getSize() const;
void clear();
private:
Modified: llvm/trunk/lib/MC/MachObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MachObjectWriter.cpp?rev=283125&r1=283124&r2=283125&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MachObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/MachObjectWriter.cpp Mon Oct 3 12:49:19 2016
@@ -882,7 +882,7 @@ void MachObjectWriter::writeObject(MCAss
sizeof(MachO::nlist_64) :
sizeof(MachO::nlist));
writeSymtabLoadCommand(SymbolTableOffset, NumSymTabSymbols,
- StringTableOffset, StringTable.data().size());
+ StringTableOffset, StringTable.getSize());
writeDysymtabLoadCommand(FirstLocalSymbol, NumLocalSymbols,
FirstExternalSymbol, NumExternalSymbols,
Modified: llvm/trunk/lib/MC/StringTableBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/StringTableBuilder.cpp?rev=283125&r1=283124&r2=283125&view=diff
==============================================================================
--- llvm/trunk/lib/MC/StringTableBuilder.cpp (original)
+++ llvm/trunk/lib/MC/StringTableBuilder.cpp Mon Oct 3 12:49:19 2016
@@ -34,6 +34,11 @@ StringTableBuilder::StringTableBuilder(K
}
}
+size_t StringTableBuilder::getSize() const {
+ assert(isFinalized());
+ return Size;
+}
+
typedef std::pair<CachedHash<StringRef>, size_t> StringPair;
// Returns the character at Pos from end of a string.
Modified: llvm/trunk/tools/yaml2obj/yaml2elf.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2elf.cpp?rev=283125&r1=283124&r2=283125&view=diff
==============================================================================
--- llvm/trunk/tools/yaml2obj/yaml2elf.cpp (original)
+++ llvm/trunk/tools/yaml2obj/yaml2elf.cpp Mon Oct 3 12:49:19 2016
@@ -307,7 +307,7 @@ void ELFState<ELFT>::initStrtabSectionHe
SHeader.sh_type = ELF::SHT_STRTAB;
CBA.getOSAndAlignedOffset(SHeader.sh_offset, SHeader.sh_addralign)
<< STB.data();
- SHeader.sh_size = STB.data().size();
+ SHeader.sh_size = STB.getSize();
SHeader.sh_addralign = 1;
}
More information about the llvm-commits
mailing list