[PATCH] D23564: [RISCV 7/10] Add RISCVInstPrinter and basic MC assembler tests

[Alex Bradbury via llvm-commits]

asb added inline comments.


> jyknight wrote in rv32i-valid.s:4
> Each of these lines should be like:
> 
>   # CHECK: addi ra, sp, 2 # encoding: [0x93,0x00,0x21,0x00]
>   addi ra, sp, 2
> 
> So that it is actually checking the output of the the InstPrinter code in addition to the encoding.

I'm about to refresh my patchset, I decided to add a `CHECK-INST` to separate the checking of assembly printing and encoding. It isn't necessary for this patch, but it's desirable when adding %lo etc:

  lui s11, %hi(0x87000000) # CHECK: encoding: [0xb7,0x0d,0x00,0x87]
  # CHECK-INST: lui s11, 552960

https://reviews.llvm.org/D23564