[PATCH] D24686: [support] Some improvements to StringSwitch

[Zachary Turner via llvm-commits]

zturner updated this revision to Diff 73295.
zturner added a comment.

Here's the updated patch, including Chandler's suggestion of using `Optional` instead of `Error`.  I thought about this some more and I don't see the value-add associated with splitting this apart.  Primarily because I abandoned the variadic templates idea.  As such, the `Lower` versions of the functions must go in at the same time as the `Lower` versions of the tests, and those two things constitue 90% of the entire patch (the rest are just case-sensitive versions of the tests for existing functions which have not changed in this patch).

Let me know if you disagree.


https://reviews.llvm.org/D24686

Files:
  include/llvm/ADT/StringSwitch.h
  unittests/ADT/CMakeLists.txt
  unittests/ADT/StringSwitchTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24686.73295.patch
Type: text/x-patch
Size: 11396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161003/d193b809/attachment.bin>