[PATCH] D23563: [RISCV 6/10] Add basic RISCVAsmParser

[James Y Knight via llvm-commits]

jyknight added inline comments.


> RISCVAsmParser.cpp:30-33
> +  MCAsmParser &Parser;
> +
> +  MCAsmParser &getParser() const { return Parser; }
> +  MCAsmLexer &getLexer() const { return Parser.getLexer(); }

Why are these here? Looks like MCTargetAsmParser already has a Parser member and these accessors.

> RISCVAsmParser.cpp:34
> +  MCAsmLexer &getLexer() const { return Parser.getLexer(); }
> +  const MCSubtargetInfo &STI;
> +

Similarly, already stored in MCTargetAsmParser, accessible via getSTI().

https://reviews.llvm.org/D23563