[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

[Dehao Chen via llvm-commits]

danielcdh added inline comments.


> dnovillo wrote in AddDiscriminators.cpp:165
> Is this the right check to perform?  This check is needed to determine whether DWARF support exists for discriminators.  How is that related to -g0?

With -g0, getDwarfVersion() will return 0. I think it's fine to have discriminators even when the debug info does not support it. It will simply not getting emitted?

https://reviews.llvm.org/D25132