[PATCH] D25184: Don't drop the llvm. prefix when renaming

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 07:01:20 PDT 2016


On 3 October 2016 at 06:58, Artur Pilipenko <apilipenko at azulsystems.com> wrote:
> apilipenko added a comment.
>
> The change seems fine, but I'm curious how we end up with an old renamed intrinsic declaration? For some reason I can't reproduce the problem locally.

If you revert just the change in lib, don't you get a crash in the testcase?


> If we materialize the whole module we must remove old declarations from the module (see BitcodeReader::materializeModule). Althought if we use BitcodeReader::materialize old declaration will be kept in the module.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D25184
>
>
>


More information about the llvm-commits mailing list