[PATCH] D25007: [DAG] Teach computeKnownBits and ComputeNumSignBits in SelectionDAG to look through EXTRACT_VECTOR_ELT.

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 01:26:36 PDT 2016


mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

The reason for my skepticism w.r.t ComputeNumSignBits was that it didn't seem to explicitly handle BUILD_VECTOR (or VSELECT, vector_shuffle, etc) explicitly.
But I guess that just gets handled through computeKnownBits.

Regarding testing - unfortunately, I don't believe there's a better way to do this right now.

LGTM.


https://reviews.llvm.org/D25007





More information about the llvm-commits mailing list