[PATCH] D24926: Added support of configuration files

[Michał Górny via llvm-commits]

mgorny added inline comments.


> CommandLine.cpp:1047
> +cl::SearchResult cl::findDefaultCfgFile(SmallVectorImpl<char> &CfgFileName,
> +                                        ArrayRef<const char *> Dirs,
> +                                        StringRef ProgramFullPath,

As I've mentioned on https://reviews.llvm.org/D24933, I think it'd be actually better to have the default dirs stored in LLVM rather than provided by the tools. This way, we can get them consistent in all LLVM tools that are going to use the configuration files, and avoid repeating them in every one of them.

https://reviews.llvm.org/D24926