[PATCH] D25039: [X86][AVX] Ensure broadcast loads respect dependencies

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

Yikes.

Thanks, Simon!
This LGTM, although maybe it can be simpler. If you think this is better as is, feel free to commit.



> X86ISelLowering.cpp:8684
> +    // and update uses of Ld's output chain to use the TokenFactor.
> +    if (Ld->hasAnyUseOfValue(1)) {
> +      SDValue NewChain = DAG.getNode(ISD::TokenFactor, DL, MVT::Other,

Why do we need the TokenFactor? The load is only used in the shuffle, right? So why can't we just replace Ld with V completely?
Or do you prefer not to trust the load being DCE'd?

Repository:
  rL LLVM

https://reviews.llvm.org/D25039