[llvm] r283039 - Use StringRef in Registry API (NFC)
Mehdi Amini via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 1 08:44:54 PDT 2016
Author: mehdi_amini
Date: Sat Oct 1 10:44:54 2016
New Revision: 283039
URL: http://llvm.org/viewvc/llvm-project?rev=283039&view=rev
Log:
Use StringRef in Registry API (NFC)
Modified:
llvm/trunk/include/llvm/Support/Registry.h
llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
Modified: llvm/trunk/include/llvm/Support/Registry.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Registry.h?rev=283039&r1=283038&r2=283039&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/Registry.h (original)
+++ llvm/trunk/include/llvm/Support/Registry.h Sat Oct 1 10:44:54 2016
@@ -25,16 +25,15 @@ namespace llvm {
/// no-argument constructor.
template <typename T>
class SimpleRegistryEntry {
- const char *Name, *Desc;
+ StringRef Name, Desc;
std::unique_ptr<T> (*Ctor)();
public:
- SimpleRegistryEntry(const char *N, const char *D, std::unique_ptr<T> (*C)())
- : Name(N), Desc(D), Ctor(C)
- {}
+ SimpleRegistryEntry(StringRef N, StringRef D, std::unique_ptr<T> (*C)())
+ : Name(N), Desc(D), Ctor(C) {}
- const char *getName() const { return Name; }
- const char *getDesc() const { return Desc; }
+ StringRef getName() const { return Name; }
+ StringRef getDesc() const { return Desc; }
std::unique_ptr<T> instantiate() const { return Ctor(); }
};
@@ -119,7 +118,7 @@ namespace llvm {
static std::unique_ptr<T> CtorFn() { return make_unique<V>(); }
public:
- Add(const char *Name, const char *Desc)
+ Add(StringRef Name, StringRef Desc)
: Entry(Name, Desc, CtorFn), Node(Entry) {
add_node(&Node);
}
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=283039&r1=283038&r2=283039&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Sat Oct 1 10:44:54 2016
@@ -2575,12 +2575,12 @@ GCMetadataPrinter *AsmPrinter::GetOrCrea
if (GCPI != GCMap.end())
return GCPI->second.get();
- const char *Name = S.getName().c_str();
+ auto Name = S.getName();
for (GCMetadataPrinterRegistry::iterator
I = GCMetadataPrinterRegistry::begin(),
E = GCMetadataPrinterRegistry::end(); I != E; ++I)
- if (strcmp(Name, I->getName()) == 0) {
+ if (Name == I->getName()) {
std::unique_ptr<GCMetadataPrinter> GMP = I->instantiate();
GMP->S = &S;
auto IterBool = GCMap.insert(std::make_pair(&S, std::move(GMP)));
More information about the llvm-commits
mailing list