[PATCH] D23252: [ADT] Zip range adapter
bryant via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 1 08:50:34 PDT 2016
bryant marked an inline comment as done.
bryant added inline comments.
> zturner wrote in STLExtras.h:245
> yes but we have `llvm::integer_sequence` in this very file. Can we use that instead?
you're right, not sure how i missed this. fixed.
> zturner wrote in STLExtras.h:251
> For STL-like classes and functions, I believe we prefer to follow STL naming conventions. So I would imagine this should be `zip_first`
are you sure about this? `Zippy`/`ZipFirst` are auxiliary classes that aren't publicly accessible.
Repository:
rL LLVM
https://reviews.llvm.org/D23252
More information about the llvm-commits
mailing list