[PATCH] D24839: [MC] Prevent out of order HashDirective lexing in AsmLexer.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 15:15:10 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



> rnk wrote in AsmLexer.h:30-35
> We should give all these scalars default member initializers and delete the assignments in the ctor.

No, I mean C++11 default member initializers, so we don't have to repeat all the scalar members in the ctor:

  class AsmLexer ... {
    ...
    const char *CurPtr = nullptr;
    bool IsAtStartOfLine = true;
    bool IsPeeking = false;
    ...

https://reviews.llvm.org/D24839





More information about the llvm-commits mailing list