[PATCH] D24818: Using branch probability to guide critical edge splitting.

[David Li via llvm-commits]

davidxl added a comment.

Can you also add an explicit test case ?



> code-placement.ll:15
>  bb:
> -; CHECK: LBB0_2:
> -; CHECK: bne LBB0_2
> -; CHECK-NOT: b LBB0_2
> +; CHECK: LBB0_1:
> +; CHECK: bne LBB0_1

Can you change it to use lit variable for the label ?

> code-placement.ll:35
>  define i32 @t2(i32 %passes, i32* nocapture %src, i32 %size) nounwind readonly {
>  entry:
>  ; CHECK-LABEL: t2:

The layout change in function 't2' is weird -- there are unnecessary branch back and forth introduced. Can you check why (not directly related to this patch -- but triggers some bugs).

https://reviews.llvm.org/D24818