[PATCH] D25128: [OCaml] Install .mli (interface) files

[Michał Górny via llvm-commits]

mgorny created this revision.
mgorny added reviewers: jpdeplaix, whitequark.
mgorny added subscribers: llvm-commits, jpdeplaix.
Herald added a subscriber: beanz.

Install the OCaml interface .mli files. Those files were most likely omitted because they are input files for the compiled .cmi files. However, installing them is reasonable since -- unlike .cmi files -- they are human-readable.

The issue was originally spotted by @jpdeplaix.


https://reviews.llvm.org/D25128

Files:
  cmake/modules/AddOCaml.cmake


Index: cmake/modules/AddOCaml.cmake
===================================================================
--- cmake/modules/AddOCaml.cmake
+++ cmake/modules/AddOCaml.cmake
@@ -180,10 +180,11 @@
 
   set(install_files)
   set(install_shlibs)
-  foreach( ocaml_output ${ocaml_outputs} )
+  foreach( ocaml_output ${ocaml_inputs} ${ocaml_outputs} )
     get_filename_component(ext "${ocaml_output}" EXT)
 
     if( NOT (ext STREQUAL ".cmo" OR
+             ext STREQUAL ".ml" OR
              ext STREQUAL CMAKE_C_OUTPUT_EXTENSION OR
              ext STREQUAL CMAKE_SHARED_LIBRARY_SUFFIX) )
       list(APPEND install_files "${ocaml_output}")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25128.73137.patch
Type: text/x-patch
Size: 638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/29f82b3b/attachment.bin>