[PATCH] D24849: Make CanUseCopyRelocWithPIE a llvm option, -pie-copy-relocations

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 13:07:47 PDT 2016


rnk added inline comments.


> TargetMachine.cpp:118-121
> +static cl::opt<bool>
> +CanUseCopyRelocWithPIE("pie-copy-relocations", cl::init(false),
> +                       cl::desc("Assume copy relocations support exists when "
> +                                "generating code for PIE executables."));

This should really live in MCTargetOptions, and not a global. We're trying to move away from cl::opt in library code.

https://reviews.llvm.org/D24849





More information about the llvm-commits mailing list