[PATCH] D24317: Emit S_COMPILE3 CodeView record

[Adrian McCarthy via llvm-commits]

amccarth added inline comments.


> rnk wrote in CodeViewDebug.cpp:2100
> I don't think we want to repeat the compile record in every symbol subsection. We have one symbol subsection per function. MSVC only emits the compiler flags once up front, like this:
> 
>   CodeViewDebugInfo [
>     Section: .debug$S (2)
>     Magic: 0x4
>     Subsection [
>       SubSectionType: Symbols (0xF1)
>       SubSectionSize: 0x5C
>       ObjectName {
>         Signature: 0x0
>         ObjectName: C:\src\llvm\build\t.obj
>       }
>       CompilerFlags3 {
>         Language: Cpp (0x1)
>         Flags [ (0x6000)
>           HotPatch (0x4000)
>           SecurityChecks (0x2000)
>         ]
>         Machine: X64 (0xD0)
>         FrontendVersion: 19.0.24210.0
>         BackendVersion: 19.0.24210.0
>         VersionName: Microsoft (R) Optimizing Compiler
>       }
>     ]
>     Subsection [
>       SubSectionType: Symbols (0xF1)
>       SubSectionSize: 0x337
>       UDT {

Good catch.  I'll fix that this afternoon and add a test for it.

Repository:
  rL LLVM

https://reviews.llvm.org/D24317