[PATCH] D25096: [RS4GC] New pass to remove gc.relocates added by RS4GC

[Anna Thomas via llvm-commits]

anna marked 2 inline comments as done.
anna added a comment.

In https://reviews.llvm.org/D25096#557526, @sanjoy wrote:

> I have some minor comments inline, but overall I'm not sure if a pass like this (solely useful for generating "debugging output") is okay to go upstream.
>
> Do you mind starting a thread on llvm-dev discussing if this sort of thing is okay with the community?


Actually, thats a good point. Especially since RS4GC is not in the pipeline of optimization passes  (in `PassManagerBuilder.cpp`). So, the only usage would be for downstream folks incorporating RS4GC in their optimization pipeline.



> sanjoy wrote in RemoveGCRelocates.cpp:69
> Didn't you just check that `GCRel->getOperand(0)` is a statepoint?  I think this can be a `cast<>`

yes, I forgot to change that to cast. I had the order of checks other way around initially :)

> sanjoy wrote in RemoveGCRelocates.cpp:72
> Why not just use the `GCRelocateInst::getBasePtr` instruction?

Ah yes. Although, I'll be using the `getDerivedPtr`.

https://reviews.llvm.org/D25096