[PATCH] D25095: [Polly] Ignore removed memory access. NFC.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 11:58:34 PDT 2016


grosser added a comment.

Hi Michael,

I am worried about a situation where we have sth like:

%val = load %A
%div = div %val, 0
store %div

If we drop the div, we might trigger undefined behavior. To my understanding this can never happen, as you will only drop direct copy sequences, right? I am probably too careful here, but if you could quickly check (assert) that the only use of %val is in a store instruction, my worries would disappear.

Also, if you commit this separately, which certainly would not hurt, a JSON test case would be amazing.

Best,
Tobias


https://reviews.llvm.org/D25095





More information about the llvm-commits mailing list