[PATCH] D25111: Improve error check for an empty archive.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 10:36:01 PDT 2016


It feels a bit much for a small warning.

How about trying to warn if there are no symbols but File->children()
is not empty?

Cheers,
Rafael

On 30 September 2016 at 10:26, Rui Ueyama <ruiu at google.com> wrote:
> ruiu created this revision.
> ruiu added a reviewer: rafael.
> ruiu added a subscriber: llvm-commits.
> Herald added a subscriber: mehdi_amini.
>
> Previously, it warned on any archive file that has no symbol.
> With this patch, it warns on such archive file that contains only
> LLVM bitcode files.
>
>
> https://reviews.llvm.org/D25111
>
> Files:
>   ELF/InputFiles.cpp
>   ELF/InputFiles.h
>   test/ELF/empty-archive.s
>   test/ELF/lto/archive.ll
>


More information about the llvm-commits mailing list