[PATCH] D25104: [compiler-rt] Add support for the dynamic shadow allocation

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

looks good



> sanitizer_posix.cc:362-363
> +uptr FindAvailableMemoryRange(uptr size, uptr alignment, uptr left_padding) {
> +  CHECK("FindAvailableMemoryRange is not available" && 0);
> +  return 0;
> +}

I think UNREACHABLE("...") is preferred

Also, this API is not really implementable on Posix. You can parse /proc/self/maps on Linux and some BSDs, which doesn't even work if you don't have access to /proc. I think at some point we'll want to come back and redesign the abstractions we're using for virtual memory allocation, but today is not that day. We already discussed how the other APIs are way too Posix-y.

https://reviews.llvm.org/D25104