[PATCH] D25108: Do not pass a superblock to PDBFileBuilder.

[Rui Ueyama via llvm-commits]

ruiu created this revision.
ruiu added a reviewer: zturner.
ruiu added a subscriber: llvm-commits.

When we create a PDB file using PDBFileBuilder, the information
in the superblock, such as the size of the resulting file, is not
available.

Previously, PDBFileBuilder::initialize took a superblock assuming
that all the members of the struct are correct. That is useful when
you want to restore the exact information from a YAML file, but
that's probably the only use case in which that is useful.
When we are creating a PDB file on the fly, we have to backfill the
members.

This patch redefines PDBFileBuilder::initialize to take only a
block size. Now all the other members are left as default values,
so that they'll be updated when commit() is called.


https://reviews.llvm.org/D25108

Files:
  include/llvm/DebugInfo/PDB/Raw/PDBFileBuilder.h
  lib/DebugInfo/PDB/Raw/PDBFileBuilder.cpp
  test/DebugInfo/PDB/pdbdump-readwrite.test
  tools/llvm-pdbdump/llvm-pdbdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25108.73079.patch
Type: text/x-patch
Size: 6281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/f3cb05ba/attachment.bin>