[PATCH] D23749: [NVPTX] Add NVPTXHoistAddrSpaceCast pass.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 09:42:07 PDT 2016


jlebar added a comment.

I am, at the moment, not convinced this is the right thing to do.

In the limited form where we only hoisted addrspacecasts up insofar as the new location "strongly dominates" the old location (that is, we hoist from location B to location A if A running guarantees that B will run), it would be possible for us to end up transforming one set of address computations into two parallel sets of computations, one in the generic space and one in the non-generic space.

It's not entirely clear to me what *is* the right thing to do, but teaching SCEV what's going on here may be a start.


https://reviews.llvm.org/D23749





More information about the llvm-commits mailing list