[PATCH] D25025: [ELF] - Do not crash on invalid symbol index.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


> InputFiles.h:154-155
>    SymbolBody &getSymbolBody(uint32_t SymbolIndex) const {
> +    if (SymbolIndex >= SymbolBodies.size())
> +      fatal("invalid symbol index");
>      return *SymbolBodies[SymbolIndex];

In the previous patch, you checked a value in a constructor of a symbol class. Here, you are checking it in InputFile. That seems inconsistent. Probably we should do all error checking in InputFile.cpp?

https://reviews.llvm.org/D25025