[PATCH] [Commented On] D25026: [asan] Move instrumented null-terminated strings to a special section
Maxim Ostapenko via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 30 02:36:06 PDT 2016
m.ostapenko added inline comments.
> AddressSanitizer.cpp:1512
> + // Move null-terminated C strings to "__asan_cstring" section on Darwin.
> + if (TargetTriple.isOSBinFormatMachO())
> + if (!G->hasSection() && G->isConstant())
Oh, too many nested ifs here. Could you use && instead?
https://reviews.llvm.org/D25026
More information about the llvm-commits
mailing list