[PATCH] [Accepted] D25067: [CMake] Support symlinks even with LLVM_INSTALL_TOOLCHAIN_ONLY

[Chris Bieneman via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One comment below. Otherwise LGTM, go ahead and commit.

Thanks for catching this!



> AddLLVM.cmake:1267
>      # Make sure both the link and target are toolchain tools
> -    if (NOT ${name} IN_LIST LLVM_TOOLCHAIN_TOOLS OR NOT ${dest} IN_LIST LLVM_TOOLCHAIN_TOOLS)
> -      return()
> +    if (${name} IN_LIST LLVM_TOOLCHAIN_TOOLS OR ${dest} IN_LIST LLVM_TOOLCHAIN_TOOLS)
> +      set(TOOL_IS_TOOLCHAIN ON)

This should actually be `AND` not `OR` since we shouldn't install the symlink without also installing the tool.

https://reviews.llvm.org/D25067