[PATCH] Do not pass a superblock to PDBFileBuilder

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 13:17:33 PDT 2016


Phab is not up yet, so I attached a patch to this mail.


When we create a PDB file using PDBFileBuilder, the information
in the superblock, such as the size of the resulting file, is not
available.

Previously, PDBFileBuilder::initialize took a superblock assuming
that all the members of the struct are correct. That is useful when
you want to restore the exact information from a YAML file, but
that's probably the only use case in which that is useful.
When we are creating a PDB file on the fly, we have to backfill the
members.

This patch redefines PDBFileBuilder::initialize to take only a
block size. Now all the other members are left as default values,
so that they'll be updated when commit() is called.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160929/2dfe70c1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pdbfilebuilder.patch
Type: application/octet-stream
Size: 39346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160929/2dfe70c1/attachment.obj>


More information about the llvm-commits mailing list