[PATCH] D23988: [compiler-rt][XRay] Support tail call sleds

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 20:19:04 PDT 2016


dberris added inline comments.

================
Comment at: lib/xray/xray_interface.cc:266
@@ +265,3 @@
+      // Here we do the dance of replacing the tail call sled with a similar
+      // sequence as the entry sled, but jump to the exit sled instead, so we
+      // can treat tail call exits as if they were normal exits. In the future
----------------
rSerge wrote:
> The comment says about a jump to the exit sled, but the code below uses `CallOpCode`. Which one is wrong?
The comment is inaccurate -- it should say "call to the exit sled instead". We need to call the exit sled so that it returns to the calling function just before the jump to the tail-called function. Let me update that.


https://reviews.llvm.org/D23988





More information about the llvm-commits mailing list