[llvm] r282655 - [LTO] Add a FIXME, we shouldn't expose getComdat().
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 28 17:31:45 PDT 2016
Author: davide
Date: Wed Sep 28 19:31:45 2016
New Revision: 282655
URL: http://llvm.org/viewvc/llvm-project?rev=282655&view=rev
Log:
[LTO] Add a FIXME, we shouldn't expose getComdat().
Thanks to Peter for the suggestion.
Modified:
llvm/trunk/include/llvm/LTO/LTO.h
Modified: llvm/trunk/include/llvm/LTO/LTO.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/LTO/LTO.h?rev=282655&r1=282654&r2=282655&view=diff
==============================================================================
--- llvm/trunk/include/llvm/LTO/LTO.h (original)
+++ llvm/trunk/include/llvm/LTO/LTO.h Wed Sep 28 19:31:45 2016
@@ -175,6 +175,8 @@ public:
// FIXME: Expose a thread-local flag for module asm symbols.
return GV && GV->isThreadLocal();
}
+
+ //FIXME: We shouldn't expose this information.
Expected<const Comdat *> getComdat() const {
if (!GV)
return nullptr;
@@ -191,6 +193,7 @@ public:
return GO->getComdat();
return nullptr;
}
+
uint64_t getCommonSize() const {
assert(Flags & object::BasicSymbolRef::SF_Common);
if (!GV)
More information about the llvm-commits
mailing list