[PATCH] D24492: [LTO] Switch to the new resolution-based API.

[Davide Italiano via llvm-commits]

On Wed, Sep 28, 2016 at 3:36 PM, Peter Collingbourne via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> I would slightly prefer not to expose it, but if it is left exposed we
> should add a FIXME. We're already exposing Comdat via Symbol::getComdat()
> and we should likely have a FIXME there as well.
>
> Peter

Thanks. I can add them, no problem. Are you fine with the rest of the
patch or you have other comments?

>
> 2016-09-28 14:57 GMT-07:00 Rafael Espíndola <rafael.espindola at gmail.com>:
>>
>> I think the only oddity I still see in the patch is exposing
>> getComdatSymbolTable. I think it is OK to have it for the first patch
>> and remove it in a follow up. Rui, Peter, what do you think?
>>
>> Cheers,
>> Rafael
>>
>>
>> 2016-09-28 13:47 GMT-07:00 Davide Italiano <dccitaliano at gmail.com>:
>> > davide updated this revision to Diff 72890.
>> > davide added a comment.
>> >
>> > run clang-format manually and it seems fine on my side.
>> >
>> >
>> > https://reviews.llvm.org/D24492
>> >
>> > Files:
>> >   lld/ELF/Error.h
>> >   lld/ELF/InputFiles.cpp
>> >   lld/ELF/InputFiles.h
>> >   lld/ELF/LTO.cpp
>> >   lld/ELF/LTO.h
>> >   lld/ELF/SymbolTable.cpp
>> >   lld/ELF/SymbolTable.h
>> >   lld/ELF/Symbols.h
>> >   lld/test/ELF/lto/archive-3.ll
>> >   lld/test/ELF/lto/asmundef.ll
>> >   lld/test/ELF/lto/available-externally.ll
>> >   lld/test/ELF/lto/common2.ll
>> >   lld/test/ELF/lto/common3.ll
>> >   lld/test/ELF/lto/discard-value-names.ll
>> >   lld/test/ELF/lto/drop-debug-info.ll
>> >   lld/test/ELF/lto/drop-linkage.ll
>> >   lld/test/ELF/lto/internalize-basic.ll
>> >   lld/test/ELF/lto/internalize-exportdyn.ll
>> >   lld/test/ELF/lto/internalize-llvmused.ll
>> >   lld/test/ELF/lto/internalize-undef.ll
>> >   lld/test/ELF/lto/internalize-version-script.ll
>> >   lld/test/ELF/lto/irmover-error.ll
>> >   lld/test/ELF/lto/linkonce-odr.ll
>> >   lld/test/ELF/lto/linkonce.ll
>> >   lld/test/ELF/lto/ltopasses-basic.ll
>> >   lld/test/ELF/lto/ltopasses-custom.ll
>> >   lld/test/ELF/lto/save-temps.ll
>> >   lld/test/ELF/lto/type-merge.ll
>> >   lld/test/ELF/lto/type-merge2.ll
>> >   lld/test/ELF/lto/unnamed-addr-comdat.ll
>> >   lld/test/ELF/lto/unnamed-addr-drop.ll
>> >   lld/test/ELF/lto/unnamed-addr-lib.ll
>> >   lld/test/ELF/lto/unnamed-addr.ll
>> >   lld/test/ELF/lto/version-script.ll
>> >   llvm/include/llvm/LTO/LTO.h
>> >
>
>
>
>
> --
> --
> Peter
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare