[PATCH] D25038: [compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 12:28:30 PDT 2016


etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, llvm-commits.
Herald added subscribers: dberris, kubabrecka.

On windows, the memcpy and memmove function can be the same.
This is correcly detected when hooking, but it's not possible
to report the right function name when doing symbolisation.

The same fix was applied for the static asan unittest.
We forgot to apply the fix for the dynamic asan tests.
```
lvm\projects\compiler-rt\test\asan/TestCases/Windows/.svn/text-base/intercept_memcpy.cc.svn-base:// CHECK-NEXT:  __asan_{{.*}}mem{{.*}}
```

This patch is fixing this test (win64):
```
ddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/dll_intercept_memcpy_indirect.cc
```

https://reviews.llvm.org/D25038

Files:
  test/asan/TestCases/Windows/dll_intercept_memcpy_indirect.cc

Index: test/asan/TestCases/Windows/dll_intercept_memcpy_indirect.cc
===================================================================
--- test/asan/TestCases/Windows/dll_intercept_memcpy_indirect.cc
+++ test/asan/TestCases/Windows/dll_intercept_memcpy_indirect.cc
@@ -24,7 +24,7 @@
   call_memcpy(&memcpy, buff2, buff1, 6);
 // CHECK: AddressSanitizer: stack-buffer-overflow on address [[ADDR:0x[0-9a-f]+]]
 // CHECK: WRITE of size 6 at [[ADDR]] thread T0
-// CHECK-NEXT:  __asan_{{.*}}memcpy
+// CHECK-NEXT:  __asan_{{.*}}mem{{.*}}
 // CHECK-NEXT:  call_memcpy
 // CHECK-NEXT:  test_function {{.*}}dll_intercept_memcpy_indirect.cc:[[@LINE-5]]
 // CHECK: Address [[ADDR]] is located in stack of thread T0 at offset {{.*}} in frame


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25038.72878.patch
Type: text/x-patch
Size: 733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160928/be08960b/attachment.bin>


More information about the llvm-commits mailing list