[PATCH] D24824: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel.

[Vasileios Kalintiris via llvm-commits]

ehostunreach added a subscriber: ehostunreach.

================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:464-465
@@ +463,4 @@
+
+  // We support only the standard encoding [MIPS32,MIPS32R6) ISAs.
+  bool UseFastISel = TM.Options.EnableFastISel && Subtarget.hasMips32() &&
+                     !Subtarget.hasMips32r6() && !Subtarget.inMips16Mode() &&
----------------
That was intentional as a coding style, ie. set UseFastISel and use the checks that follow to unset it. I merged the ISA-checks together.

================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:467-469
@@ +466,5 @@
+                     !Subtarget.hasMips32r6() && !Subtarget.inMips16Mode() &&
+                     !Subtarget.inMicroMipsMode();
+
+  // Disable if we don't generate PIC or the ABI isn't O32.
+  if (!TM.isPositionIndependent() || !TM.getABI().IsO32())
----------------
I added a check for the MIPS16 mode and a test case as well. 


https://reviews.llvm.org/D24824