[PATCH] D24416: Unit test for Conditionally eliminate library calls

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: SingleSource/Regression/C++/cdce_macro.inc:16
@@ +15,3 @@
+
+#ifndef str
+#define str(s) s
----------------
use upper case for macro?

Why is the macro needed?

================
Comment at: SingleSource/Regression/C++/cdce_macro.inc:20
@@ +19,3 @@
+
+#define RANGE 10
+#define TESTCODEVAL(FUNC, VAL)                                                 \
----------------
why 10 ?

================
Comment at: SingleSource/Regression/C++/cdce_macro.inc:21
@@ +20,3 @@
+#define RANGE 10
+#define TESTCODEVAL(FUNC, VAL)                                                 \
+  {                                                                            \
----------------
-->TEST_VAL_RANGE?

================
Comment at: SingleSource/Regression/C++/cdce_macro.inc:33
@@ +32,3 @@
+
+#define TESTCODE(FUNC)                                                         \
+  {                                                                            \
----------------
-->TEST_VAL

This macro be used in TEST_VAL_RANGE definition

================
Comment at: SingleSource/Regression/C++/cdce_macro.inc:33
@@ +32,3 @@
+
+#define TESTCODE(FUNC)                                                         \
+  {                                                                            \
----------------
davidxl wrote:
> -->TEST_VAL
> 
> This macro be used in TEST_VAL_RANGE definition
make it take a value argument


https://reviews.llvm.org/D24416