[PATCH] D24492: [LTO] Switch to the new resolution-based API.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 10:18:55 PDT 2016


davide added inline comments.

================
Comment at: lld/ELF/InputFiles.cpp:661
@@ -679,1 +660,3 @@
+      return Symtab<ELFT>::X->addUndefined(NameRef, Binding, Visibility, Type,
+                                           CanOmitFromDynSym, false, F);
 
----------------
rafael wrote:
> You have lost HasUnnamedAddr. Where do you compensate for that?
I think it's not needed anymore becuase lib/LTO will compute it based on `GlobalResolution`.
I'm garbage collecting it for now.


https://reviews.llvm.org/D24492





More information about the llvm-commits mailing list