[PATCH] D24683: [DAGCombine] Generalize build_vector -> vector_shuffle combine for more than 2 inputs

[Zvi Rackover via llvm-commits]

zvi added a comment.

Great job!


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12884
@@ +12883,3 @@
+SDValue DAGCombiner::createBuildVecShuffle(
+    SDLoc DL, SDNode *N, const SmallVectorImpl<int> &VectorMask, SDValue VecIn1,
+    SDValue VecIn2, unsigned LeftIdx) {
----------------
consider changing type of VectorMask to ArrayRef<int> 


https://reviews.llvm.org/D24683