[PATCH] D24955: [ValueTracking] Teach computeKnownBits and ComputeNumSignBits to look through ExtractElement.

[Bjorn Pettersson via llvm-commits]

bjope updated this revision to Diff 72825.
bjope added a comment.

Corrected type in test case and auto-generated FileCheck assertions.

We should probably wait for relaxed checks in a clang test case (see https://reviews.llvm.org/D24397 ) before commit.
But I hope someone will help me commit this when that test case has been corrected.


https://reviews.llvm.org/D24955

Files:
  lib/Analysis/ValueTracking.cpp
  test/Analysis/ValueTracking/signbits-extract-elt.ll

Index: test/Analysis/ValueTracking/signbits-extract-elt.ll
===================================================================
--- /dev/null
+++ test/Analysis/ValueTracking/signbits-extract-elt.ll
@@ -0,0 +1,28 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -instsimplify -S | FileCheck %s
+
+; If computeKnownBits can do a simple look-through for extractelement
+; then instsimplify will know that %elt1 is non-negative at icmp.
+define i1 @computeKnownBits_look_through_extractelt(<2 x i8> %vecin) {
+; CHECK-LABEL: @computeKnownBits_look_through_extractelt(
+; CHECK-NEXT:    ret i1 false
+;
+  %vec = zext <2 x i8> %vecin to <2 x i32>
+  %elt1 = extractelement <2 x i32> %vec, i32 1
+  %bool = icmp slt i32 %elt1, 0
+  ret i1 %bool
+}
+
+; If computeNumSignBits can do a simple look-through for extractelement
+; then instsimplify will remove the ashr.
+define i32 @computeNumSignBits_look_through_extractelt(<2 x i1> %vecin) {
+; CHECK-LABEL: @computeNumSignBits_look_through_extractelt(
+; CHECK-NEXT:    [[VEC:%.*]] = sext <2 x i1> [[VEC:%.*]]in to <2 x i32>
+; CHECK-NEXT:    [[ELT0:%.*]] = extractelement <2 x i32> [[VEC]], i32 0
+; CHECK-NEXT:    ret i32 [[ELT0]]
+;
+  %vec = sext <2 x i1> %vecin to <2 x i32>
+  %elt0 = extractelement <2 x i32> %vec, i32 0
+  %ashr = ashr i32 %elt0, 5
+  ret i32 %ashr
+}
Index: lib/Analysis/ValueTracking.cpp
===================================================================
--- lib/Analysis/ValueTracking.cpp
+++ lib/Analysis/ValueTracking.cpp
@@ -1389,6 +1389,13 @@
       }
     }
     break;
+  case Instruction::ExtractElement:
+    // Look through extract element. At the moment we keep this simple and skip
+    // tracking the specific element. But at least we might find information
+    // valid for all elements of the vector (for example if vector is sign
+    // extended, shifted, etc).
+    computeKnownBits(I->getOperand(0), KnownZero, KnownOne, Depth + 1, Q);
+    break;
   case Instruction::ExtractValue:
     if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I->getOperand(0))) {
       const ExtractValueInst *EVI = cast<ExtractValueInst>(I);
@@ -2220,6 +2227,13 @@
     // FIXME: it's tricky to do anything useful for this, but it is an important
     // case for targets like X86.
     break;
+
+  case Instruction::ExtractElement:
+    // Look through extract element. At the moment we keep this simple and skip
+    // tracking the specific element. But at least we might find information
+    // valid for all elements of the vector (for example if vector is sign
+    // extended, shifted, etc).
+    return ComputeNumSignBits(U->getOperand(0), Depth + 1, Q);
   }
 
   // Finally, if we can prove that the top bits of the result are 0's or 1's,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24955.72825.patch
Type: text/x-patch
Size: 2768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160928/ff5024b5/attachment.bin>