[PATCH] D25014: [ELF] Change the way we compute file offsets

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 04:56:00 PDT 2016


evgeny777 added inline comments.

================
Comment at: ELF/Writer.cpp:1055
@@ -1052,3 +1054,3 @@
     if (!(Sec->getFlags() & SHF_ALLOC))
-      break;
+      continue;
 
----------------
grimar wrote:
> Why do you need this ?
This patch was done in times we could have non-allocatable sections in the middle of the section list. This is no longer needed as well as taking maximum of old and new offset. I'll update the diff.


Repository:
  rL LLVM

https://reviews.llvm.org/D25014





More information about the llvm-commits mailing list