[PATCH] D24625: [DAG] Remove isVectorClearMaskLegal() check from vector_build dagcombine

[Michael Kuperstein via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL282567: [DAG] Remove isVectorClearMaskLegal() check from vector_build dagcombine (authored by mkuper).

Changed prior to commit:
  https://reviews.llvm.org/D24625?vs=71543&id=72764#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D24625

Files:
  llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/trunk/test/CodeGen/AMDGPU/r600-export-fix.ll
  llvm/trunk/test/CodeGen/SystemZ/vec-perm-13.ll

Index: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -13064,13 +13064,6 @@
     Mask[i] = Vec2Offset + ExtIndex;
   }
 
-  // Avoid introducing illegal shuffles with zero.
-  // TODO: This doesn't actually do anything smart at the moment.
-  // We should either delete this, or check legality for all the shuffles
-  // we create.
-  if (UsesZeroVector && !TLI.isVectorClearMaskLegal(Mask, VT))
-    return SDValue();
-
   // The type the input vectors may have changed above.
   InVT1 = VecIn1.getValueType();
 
Index: llvm/trunk/test/CodeGen/SystemZ/vec-perm-13.ll
===================================================================
--- llvm/trunk/test/CodeGen/SystemZ/vec-perm-13.ll
+++ llvm/trunk/test/CodeGen/SystemZ/vec-perm-13.ll
@@ -19,8 +19,8 @@
 ; CHECK-VECTOR-NEXT: .space  1                                        
 ; CHECK-VECTOR-NEXT: .byte   6
 ; CHECK-VECTOR-NEXT: .byte   7
-; CHECK-VECTOR-NEXT: .byte   16
-; CHECK-VECTOR-NEXT: .byte   17
+; CHECK-VECTOR-NEXT: .byte   22
+; CHECK-VECTOR-NEXT: .byte   23
 ; CHECK-VECTOR-NEXT: .space  1                                        
 ; CHECK-VECTOR-NEXT: .space  1                                        
 ; CHECK-VECTOR-NEXT: .space  1                                        
Index: llvm/trunk/test/CodeGen/AMDGPU/r600-export-fix.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/r600-export-fix.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/r600-export-fix.ll
@@ -3,9 +3,9 @@
 ;CHECK:	EXPORT T{{[0-9]}}.XYZW
 ;CHECK:	EXPORT T{{[0-9]}}.0000
 ;CHECK: EXPORT T{{[0-9]}}.0000
-;CHECK: EXPORT T{{[0-9]}}.0XYZ
+;CHECK: EXPORT T{{[0-9]}}.0YZW
 ;CHECK: EXPORT T{{[0-9]}}.XYZW
-;CHECK: EXPORT T{{[0-9]}}.YZ00
+;CHECK: EXPORT T{{[0-9]}}.XY00
 ;CHECK: EXPORT T{{[0-9]}}.0000
 ;CHECK: EXPORT T{{[0-9]}}.0000
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24625.72764.patch
Type: text/x-patch
Size: 1999 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160928/00471723/attachment.bin>