[PATCH] D21719: Unroll restructure

[Michael Zolotukhin via llvm-commits]

mzolotukhin accepted this revision.
mzolotukhin added a comment.
This revision is now accepted and ready to land.

LGTM with minor nits.

Thanks,
Michael


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:127
@@ -126,2 +126,3 @@
   UP.FullUnrollMaxCount = UINT_MAX;
+  UP.BEInsns = 2;
   UP.Partial = false;
----------------
It would make sense to add the initialization to `getUnrollingPreferences` in `BasicTTIImpl.h`.

================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:694
@@ +693,3 @@
+// Returns loop size estimation for unrolled loop.
+static uint64_t UnrolledLoopSize(
+    unsigned LoopSize,
----------------
Please use verbs for function names and start them from lower-case.

================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:743
@@ -739,3 +742,3 @@
 
   uint64_t UnrolledSize;
 
----------------
Is this unused now?


Repository:
  rL LLVM

https://reviews.llvm.org/D21719